Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subjects: added datastream for bodc #445

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

0einstein0
Copy link
Member

@0einstein0 0einstein0 commented Nov 27, 2024

❤️ Thank you for your contribution!

Description

Closes #444

Screenshot 2024-11-27 at 10 22 09 Screenshot 2024-11-27 at 10 24 17

record

"subjects": [
        {
          "id": "SDN:P01::SAGEMSFM",
          "subject": "AMSSedAge",
          "scheme": "BODC-PUV",
          "@v": "209a4630-6dad-4609-9d91-d832ab6f15cc::1"
        },
        {
          "id": "SDN:P01::ZAGESCBX",
          "subject": "Shell14CAge",
          "scheme": "BODC-PUV",
          "@v": "74da087d-601c-4aaa-b3d6-67f91e04c541::1"
        }
      ],

db

{
  "id": "SDN:P01::SAGEMSGB",
  "pid": {
    "pk": 172411,
    "status": "R",
    "obj_type": "rec",
    "pid_type": "sub"
  },
  "props": {"definition": "Accelerated mass spectrometry on picked tests"},
  "title": {
    "en": "14c age of globigerina bulloides (itis: 45797: worms 113434) [subcomponent: tests] in sediment by picking and accelerator mass spectrometry"
  },
  "scheme": "BODC-PUV",
  "$schema": "local://subjects/subject-v1.0.0.json",
  "subject": "AMSSedAge",
  "identifiers": [
    {
      "scheme": "url",
      "identifier": "http://vocab.nerc.ac.uk/collection/P01/current/SAGEMSGB/"
    }
  ]
}

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0 0einstein0 force-pushed the vocab-nvs branch 2 times, most recently from 562f13c to e8dd5da Compare November 27, 2024 13:01
@0einstein0 0einstein0 force-pushed the vocab-nvs branch 2 times, most recently from c802cf1 to f9e30ae Compare November 28, 2024 15:48
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor things and an issue I'll shelve

invenio_vocabularies/contrib/subjects/bodc/datastreams.py Outdated Show resolved Hide resolved
invenio_vocabularies/factories.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor/shelve: this file is starting to grow somewhat, so I'll shelve an issue to see how we can refactor it and have some sort of "pluggable" system

@slint slint merged commit 196dfc6 into inveniosoftware:master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate NVS P01 collection subjects in vocabularies
5 participants